r2.17.1 #10045
Merged
r2.17.1 #10045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#minor-release PiperOrigin-RevId: 430454251 (cherry picked from commit f310a57)
Generated by running: ./gradlew wrapper --gradle-version 7.4 --distribution-type all #minor-release PiperOrigin-RevId: 430666317 (cherry picked from commit 8416f46)
The command is not needed, because the specified branch is already the default branch on GitHub so will be checked out by clone automatically. PiperOrigin-RevId: 430910549 (cherry picked from commit 6ed72dc)
When a live stream is joined while ads are already playing, the LOADED event is missed and we don't have ad information for those ads in the ad group that are before the ad index at which we joined. This way we can clip the duration when we receive the LOADED event for the last ad in the group. This fixes the problem of the playback controls being hidden when content resumes after the ad group. #minor-release PiperOrigin-RevId: 431269627 (cherry picked from commit da00f0c)
PiperOrigin-RevId: 431376857 (cherry picked from commit 95c74f0)
PiperOrigin-RevId: 431395359 (cherry picked from commit f66c929)
PiperOrigin-RevId: 432154626 (cherry picked from commit 733cd60)
PiperOrigin-RevId: 432189509 (cherry picked from commit e66d0c9)
This makes the reading period advance early as expected at the end of an ad period. Before this change the reading position of the metadata renderer prevented advancing the period until metadata arrived after the start position of the following period. Only then the reading position of the metadata renderer is updated and beyond the start position of the following period which is a condition to advance the reading period. Because transitioning to the next period is a virtual transition and the SharedMediaPeriod keeps reading from the same underlying sample streams, the metadata renderer can safely be ignored for this check. PiperOrigin-RevId: 432646037 (cherry picked from commit 25e5680)
PiperOrigin-RevId: 433467068 (cherry picked from commit 153b16a)
#minor-release PiperOrigin-RevId: 433499164 (cherry picked from commit 72bda9e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.