Skip to content

Forced subtitle DASH support checking for wrong Role@value #9727

Closed
@theRealRobG

Description

@theRealRobG

When checking for forced subtitle behaviour in the DashManifestParser.java, the Role@value being matched against is forced_subtitle:
https://github.com/google/ExoPlayer/blob/r2.16.1/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1477
https://github.com/google/ExoPlayer/blob/r2.16.1/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1547

But according to the 4th edition of ISO/IEC 23009-1 (publicly available here) this should be checking for forced-subtitle. This is defined in Table 31 — Role@value attribute for scheme with a value "urn:mpeg:dash:role:2011":

Role@value Description Applicable Media Type(s) (Informative)
forced-subtitle Textual information meant for display when no other text representation is selected. It is used to clarify dialogue, alternate languages, texted graphics or location/person IDs that are not otherwise covered in the dubbed/localized audio. text

Table 31 — Role@value attribute for scheme with a value "urn:mpeg:dash:role:2011"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions