Fix deadlock in GREYRemoteExecutor by stopping run loop directly from background thread. - #2170
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix deadlock in GREYRemoteExecutor by stopping run loop directly from background thread.#2170copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
… background thread. Previously, the runner attempted to unblock the main thread by dispatching a block to the main queue that calls CFRunLoopStop. However, when the main thread is spinning in CFRunLoopRun, blocks dispatched to the main queue are not processed. We now call CFRunLoopStop(mainRunLoop) directly from the background thread targeting the main run loop. PiperOrigin-RevId: 934944984
copybara-service
Bot
force-pushed
the
test_934944984
branch
from
June 22, 2026 20:46
8a7ccd8 to
171aef1
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deadlock in GREYRemoteExecutor by stopping run loop directly from background thread.
Previously, the runner attempted to unblock the main thread by dispatching a block to the main queue that calls CFRunLoopStop. However, when the main thread is spinning in CFRunLoopRun, blocks dispatched to the main queue are not processed. We now call CFRunLoopStop(mainRunLoop) directly from the background thread targeting the main run loop.