Skip to content

Properly propagate touch injector error. #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: earlgrey2
Choose a base branch
from
Open

Properly propagate touch injector error. #2087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions AppFramework/Event/GREYTouchInjector.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ - (BOOL)grey_injectTouches:(GREYTouchInfo *)touchInfo
ongoingTouches:(NSMutableArray<UITouch *> *)ongoingTouches
exception:(NSException **)exception {
GREYFatalAssertMainThread();
id injectionException;

UITouchesEvent *event = [UIApplication.sharedApplication _touchesEvent];
[self grey_updateUITouchObjectsFromTouchInfo:touchInfo
ongoingTouches:ongoingTouches
Expand Down Expand Up @@ -385,12 +385,13 @@ - (BOOL)grey_injectTouches:(GREYTouchInfo *)touchInfo
@autoreleasepool {
[UIApplication.sharedApplication sendEvent:event];
}
} @catch (id exception) {
injectionException = exception;
} @catch (id injectionException) {
*exception = injectionException;
return false;
} @finally {
[event _setHIDEvent:NULL];
}
return !injectionException;
return true;
}

/**
Expand Down