Convert CommissionablesFragment to Jetpack Compose. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://developer.android.com/codelabs/jetpack-compose-migration#0 for background information. Still in Step 1: very simple migration as a first step. bottom-up approach where we simply migrate the Inspect screen view subtree that is shown when a device is being inspected. Note that we still have a couple FIXME's. They could stay around until migration to Compose has been completed if the fixes are not obvious in this hybrid (xml view / compose) world.
tunjid
reviewed
Jan 25, 2024
...stem/src/main/java/com/google/homesampleapp/screens/commissionable/CommissionableFragment.kt
Outdated
Show resolved
Hide resolved
tunjid
reviewed
Jan 25, 2024
...stem/src/main/java/com/google/homesampleapp/screens/commissionable/CommissionableFragment.kt
Outdated
Show resolved
Hide resolved
tunjid
reviewed
Jan 25, 2024
...stem/src/main/java/com/google/homesampleapp/screens/commissionable/CommissionableFragment.kt
Show resolved
Hide resolved
tunjid
reviewed
Jan 25, 2024
tunjid
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.android.com/codelabs/jetpack-compose-migration#0 for background information. Still in Step 1: very simple migration as a first step. bottom-up approach where we simply migrate the Inspect screen view subtree that is shown when a device is being inspected.
Note that we still have a couple FIXME's.
They could stay around until migration to Compose has been completed if the fixes are not obvious in this hybrid (xml view / compose) world.