Add update_strategy for envvars and secrets - #523
Merged
Conversation
verbanicm
previously approved these changes
May 16, 2024
sethvargo
force-pushed
the
sethvargo/update_strat
branch
6 times, most recently
from
May 17, 2024 02:42
98e15a7 to
32a6378
Compare
Contributor
Author
|
Hmm - I'm not sure what's going on. Integration tests are suddenly failing, even at HEAD. It looks like something changed in the node.js test suite with data being shared between filters? |
sethvargo
force-pushed
the
sethvargo/update_strat
branch
from
May 17, 2024 03:28
32a6378 to
647937e
Compare
Contributor
Author
|
sethvargo
force-pushed
the
sethvargo/update_strat
branch
from
May 17, 2024 03:34
647937e to
38e5d68
Compare
sethvargo
disabled auto-merge
May 17, 2024 03:36
The default behavior remains to merge (--update), but setting the update_strategy to "overwrite" will set all values.
sethvargo
force-pushed
the
sethvargo/update_strat
branch
from
May 17, 2024 03:38
38e5d68 to
c3ff7e5
Compare
sethvargo
enabled auto-merge (squash)
May 17, 2024 03:40
sethvargo
disabled auto-merge
May 17, 2024 03:41
Merged
sethvargo
pushed a commit
that referenced
this pull request
May 17, 2024
## What's Changed * Add update_strategy for envvars and secrets by @sethvargo in #523 **Full Changelog**: v2.5.0...42ca54d
|
Thanks a lot 🫶! That was fast 🚀 |
|
Quick FYI: Works like a charm in our deployment. Goodbye env var called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior remains to merge (--update), but setting the update_strategy to "overwrite" will set all values.
Closes #522