Add integration tests to Test CI worfklow #166
Conversation
.github/workflows/test.yml
Outdated
|
|
||
| - name: run node iTests | ||
| env: | ||
| GEMINI_API_KEY: ${{secrets.GEMINI_API_KEY}} |
There was a problem hiding this comment.
Nit:
| GEMINI_API_KEY: ${{secrets.GEMINI_API_KEY}} | |
| GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }} |
| - name: Use Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} |
There was a problem hiding this comment.
Since we're using setup-node@v3 and yarn <= 2, I think we can use caching to speed up dependency installs
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-data
There was a problem hiding this comment.
I couldn't find it, but does it say if it will upgrade to the latest version within semver, or if it finds a version in the cache that matches semver it will just use it, even if it's not the latest? I skimmed and I found a flag for managing the latest version of Node but it doesn't seem to apply to the packages. I don't know if matters that much though, just something to remember if there's any discrepancy between CI and local test runs.
There was a problem hiding this comment.
@dlarocque Done!
.github/workflows/test.yml
Outdated
|
|
||
| - name: run web iTests | ||
| env: | ||
| GEMINI_API_KEY: ${{secrets.GEMINI_API_KEY}} |
There was a problem hiding this comment.
Nit:
| GEMINI_API_KEY: ${{secrets.GEMINI_API_KEY}} | |
| GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }} |
| @@ -20,12 +20,10 @@ on: | |||
| branches: main | |||
|
|
|||
| jobs: | |||
| test: | |||
| unit-test: | |||
There was a problem hiding this comment.
Don't forget to go into the settings and change the required tests - this changes the CI job name and the required check goes by name.
There was a problem hiding this comment.
Yep, it's in the PR comments above. I won't forget!
| - name: Use Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} |
There was a problem hiding this comment.
I couldn't find it, but does it say if it will upgrade to the latest version within semver, or if it finds a version in the cache that matches semver it will just use it, even if it's not the latest? I skimmed and I found a flag for managing the latest version of Node but it doesn't seem to apply to the packages. I don't know if matters that much though, just something to remember if there's any discrepancy between CI and local test runs.
.github/workflows/test.yml
Outdated
| env: | ||
| GEMINI_API_KEY: ${{secrets.GEMINI_API_KEY}} | ||
| run: | | ||
| cd packages/main |
There was a problem hiding this comment.
yarn --cwd packages/main test:node:integration if you want to save a line. Also for web below
Add the integration tests to the test worfklow.
Remove one more integration test that exercises blocked content.
Note: when this is approved and ready to merge, update the GitHub main branch required tests to include the new integration tests and remove the older test name format.