AbortSignal support #144
Merged
AbortSignal support #144
+590
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
reviewed
May 20, 2024
hsubox76
reviewed
May 21, 2024
docs/reference/files/generative-ai.googleaifilemanager.deletefile.md
Outdated
Show resolved
Hide resolved
| import { GoogleAIFileManager } from "../../dist/files"; | ||
|
|
||
| use(chaiAsPromised); | ||
|
|
||
| /** | ||
| * Integration tests against live backend. | ||
| */ | ||
| describe("abortSignal", function () { | ||
| describe("signal", function () { |
There was a problem hiding this comment.
Can you add a test to see if this works together with timeout (e.g., whichever comes first works)? Or if it's too hard to make an automated test, can you test it manually?
gaodeng
approved these changes
Jun 29, 2024
|
any news? |
This was referenced Sep 18, 2024
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
SingleRequestOptionswithAbortSignalsupport to most of the asynchronous methods of:GenerativeModelGoogleAIFileManagerChatSessionNOTE:
AbortSignalis a client-only operation. Using it to cancel an operation will not cancel the request in the service. You will still be charged usage for any applicable operations.Some methods are not supported as they would leave the server in an ambiguous state, namely
GoogleAIFileManager.uploadFile()andGoogleAIFileManager.deleteFile().