Add common proguard rules #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlazo
approved these changes
May 6, 2024
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
When we migrated to common, our types got moved and the proguard rule no longer applied. I think this should be adequate to handle all of our serialized types, but if there are more outside of common that'll also need to be kept.
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
When we migrated to common, our types got moved and the proguard rule no longer applied. I think this should be adequate to handle all of our serialized types, but if there are more outside of common that'll also need to be kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated to common, our types got moved and the proguard rule no longer applied. I think this should be adequate to handle all of our serialized types, but if there are more outside of common that'll also need to be kept.