fix(core): preserve explicit flash model IDs - #28893
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the static model resolver to ensure that explicit model IDs are not incorrectly rewritten to the Gemini 3.5 Flash target. By narrowing the scope of the rollout logic, the system now correctly preserves specific model versions while still allowing the generic 'flash' alias to be promoted as intended. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/M
|
There was a problem hiding this comment.
Code Review
This pull request refactors the model resolution logic in packages/core/src/config/models.ts by removing the isFlashModel helper function and explicitly checking for specific flash model identifiers and aliases during the Gemini 3.5 Flash rollout. It also introduces a new test suite in models.explicit-flash.test.ts to verify that explicit flash model IDs are preserved correctly. No review comments were provided, so there is no additional feedback.
Fixes #28859
Summary
flashalias and known rollout IDsgemini-3.6-flashandgemini-3.7-flashWhy
The static resolver could rewrite explicit model IDs ending in
flashto the Gemini 3.5 Flash rollout target. This made published models unreachable by name and allowed nonexistent model IDs to appear to work.Validation
Added focused unit coverage in
packages/core/src/config/models.explicit-flash.test.ts.Opening as draft because the full repository preflight was not available in this environment.