fix(core): ignore .gemini folder by default in file search - #28866
fix(core): ignore .gemini folder by default in file search#28866Rajeev91691 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves file discovery performance and stability by ensuring that the .gemini configuration directory is ignored by default. This change prevents workspace crawlers and filesystem watchers from indexing internal files within .gemini, which previously caused performance overhead and false warnings in environments where this directory is present. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
There was a problem hiding this comment.
Code Review
This pull request updates the file search utility to always include '.gemini' in the list of ignored directories, ensuring it is excluded from file discovery by default. A unit test has also been added to verify this behavior. There are no review comments, and I have no feedback to provide.
This PR adds
.geminito the list of default ignored directories inloadIgnoreRules(Issue #28826).When running the tool within workspaces that contain the
.geminiconfiguration directory (e.g. running in user's home directory), chokidar filesystem watchers and workspace crawlers attempt to index internal directories. This causes spurious file discovery events, indexing delays, and warnings when short-lived runtime lockfiles (likeprojects.json.lock) are created and deleted quickly.Adding
.geminito default ignored directories resolves this. Added unit tests inpackages/core/src/utils/filesearch/ignore.test.tsto ensure.geminiis always excluded.