Update public workflow trust and readme - #28098
Closed
DavidAPierce wants to merge 1 commit into
Closed
Conversation
|
📊 PR Size: size/L
|
|
Size Change: -4 B (0%) Total Size: 35.2 MB
ℹ️ View Unchanged
|
Contributor
Author
|
#27947 has already addressed this. Closing PR. |
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR remediates potential privilege escalation and secret exfiltration within GitHub Actions workflows that process untrusted public inputs (such as issue titles, bodies, and comments).
By removing
GEMINI_CLI_TRUST_WORKSPACE: 'true'and setting"tools": {"core": []}, we prevent pull requests or issue inputs from abusing workspace-level configuration settings. Security best practices have been added to our documentation andREADME.md.Details
The security hardening includes the following:
Workflow Refactoring & De-tooling:
.github/workflows/gemini-automated-issue-triage.yml:Prepare Issue Datastep (which createdissue_context.md).GEMINI_CLI_TRUST_WORKSPACE: 'true'so that the CLI runs in restricted "safe mode" and strictly ignores any local workspace settings files (.gemini/settings.json) submitted in PRs."tools": {"core": []}in the workflow's global settings, making any prompt injection trying to run file/shell commands entirely inert..github/workflows/gemini-automated-issue-dedup.yml: RemovedGEMINI_CLI_TRUST_WORKSPACE: 'true'..github/workflows/gemini-cli-bot-brain.yml: RemovedGEMINI_CLI_TRUST_WORKSPACE: 'true'..github/workflows/gemini-scheduled-issue-triage.yml: Removed both standard and effort triage occurrences ofGEMINI_CLI_TRUST_WORKSPACE: 'true'.Security Documentation & Alerts Added:
docs/cli/trusted-folders.md: Added a highly visible, sentence-cased[!WARNING]callout detailing the security implications of bypassing trust checks in pipelines processing public, untrusted inputs.README.md: Added a corresponding warning note under the "GitHub Integration" section to capture any developer setting up the GitHub Action.How to Validate
.github/workflows/gemini-automated-issue-triage.ymlto confirm clean YAML formatting and correct inline context interpolation.Pre-Merge Checklist