Skip to content

Enable NumericalRouter when using dynamic model configs #26929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjwang1 merged 3 commits into from
May 12, 2026
Merged

Enable NumericalRouter when using dynamic model configs #26929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86136bf
Enable NumericalRouter when using dynamic model configs
kevinjwang1 May 12, 2026
1f8b9da
Merge branch 'main' into enableNumericalClassifier
kevinjwang1 May 12, 2026
20afef4
Merge branch 'main' into enableNumericalClassifier
kevinjwang1 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/config/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@
): boolean {
if (config?.getExperimentalDynamicModelConfiguration?.() === true) {
// Legacy behavior resolves the model first.
const resolved = resolveModel(model);
const resolved = resolveModel(model, false, false, false, true, config);
return (
config.modelConfigService.getModelDefinition(resolved)?.family ===
'gemini-3'
Expand All @@ -365,7 +365,7 @@
export function isGemini2Model(model: string): boolean {
// This is legacy behavior, will remove this when gemini 2 models are no
// longer needed.
return /^gemini-2(\.|$)/.test(model);

Check warning on line 368 in packages/core/src/config/models.ts

View workflow job for this annotation

GitHub Actions / Lint 

Found sensitive keyword "gemini-2". Please make sure this change is appropriate to submit.
}

/**
Expand Down
Loading