feat: add CTRL+b to background shell tasks

[fd44fdg]

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @fd44fdg, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature that allows users to background active shell tasks by pressing CTRL+b. This enhancement provides greater control over long-running commands, enabling them to execute asynchronously without tying up the terminal interface. The changes involve integrating the CTRL+b key binding into the shell input prompt, extending the ShellExecutionService with a robust detachment capability, and updating the shell tool invocation logic to accurately report the status of backgrounded processes.

Highlights

• New Keyboard Shortcut: A new keyboard shortcut, CTRL+b, has been added to allow users to background the currently active shell task.
• Shell Task Detachment: A mechanism has been introduced to detach running pseudo-terminal (PTY) processes, enabling them to continue execution in the background without blocking the foreground.
• Improved Status Reporting: The system now differentiates between aborted and backgrounded shell commands, providing specific output messages and a backgrounded flag in the ShellExecutionResult to reflect the new state.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature to detach and background running shell tasks using CTRL+b. However, a high-severity prompt injection vulnerability was identified in packages/core/src/tools/shell.ts due to feeding raw shell command output to the LLM, which could allow attacker manipulation. A mitigation strategy involving wrapping output in a markdown code block is recommended. Furthermore, a critical memory leak exists in the detach implementation where PTY listeners are not cleaned up, potentially causing significant memory issues for long-running backgrounded processes. Detailed feedback and a suggested fix for this memory leak are provided in the review.