-
Notifications
You must be signed in to change notification settings - Fork 10.3k
fix(patch): cherry-pick e9a601c to release/v0.23.0-preview.3-pr-15465 to patch version v0.23.0-preview.3 and create version 0.23.0-preview.4 #15682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patch): cherry-pick e9a601c to release/v0.23.0-preview.3-pr-15465 to patch version v0.23.0-preview.3 and create version 0.23.0-preview.4 #15682
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick that updates the CLI's configuration schema to introduce a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +277 B (0%) Total Size: 22 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a type field for mcpServers configuration to explicitly define the transport protocol (stdio, sse, http), which improves clarity. The schema and tests have been updated accordingly. My main feedback is to address the potential ambiguity and configuration conflict between the existing httpUrl property and the new ability to use url with type: 'http', which could lead to confusion. I've suggested deprecating httpUrl to prevent misconfiguration.
55b0c5c
into
release/v0.23.0-preview.3-pr-15465
This PR automatically cherry-picks commit e9a601c to patch version v0.23.0-preview.3 in the preview release to create version 0.23.0-preview.4.