Skip to content

Conversation

@gemini-cli-robot
Copy link
Collaborator

This PR automatically cherry-picks commit 9cdb267 to patch version v0.23.0-preview.1 in the preview release to create version 0.23.0-preview.2.

Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a delightful holiday-themed animation into the CLI's header display. By introducing the useSnowfall hook, the application can now dynamically enhance its ASCII art with falling snow and festive Christmas trees. This feature is designed to activate only during the holiday season (December and January) and when the 'Holiday' theme is selected, providing a charming, time-limited visual experience that gracefully deactivates after 15 seconds or upon user interaction, ensuring it complements the user interface without disruption.

Highlights

  • New Holiday Animation Hook: Introduced a new useSnowfall React hook that applies a festive, holiday-themed animation to the CLI's header ASCII art.
  • Conditional Animation Display: The animation is conditional, appearing only during December and January, when the 'Holiday' theme is active, if the terminal is wide enough, and if no chat interaction has occurred.
  • Animation Duration: The holiday animation automatically stops after 15 seconds to ensure it's a temporary visual flourish.
  • Test Updates: Updated existing AppHeader tests to include a history property in the uiState mock, and added new dedicated tests for the useSnowfall hook.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Size Change: +3.76 kB (+0.02%)

Total Size: 22 MB

Filename Size Change
./bundle/gemini.js 22 MB +3.76 kB (+0.02%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a holiday-themed 'snowfall' animation to the application's header. The changes primarily involve a new useSnowfall React hook, its integration into the Header component, and associated unit tests. The implementation is generally solid, but I've found a performance issue in the new hook that could affect UI responsiveness as the chat history increases. My review provides a specific suggestion to optimize this.

Comment on lines +68 to +70
const hasStartedChat = history.some(
(item) => item.type === 'user' && item.text !== '/theme',
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The hasStartedChat variable is recalculated on every render. Since this hook is used for an animation that triggers re-renders every 150ms, iterating over the history array on each render can become a performance bottleneck as the chat history grows. This calculation should be memoized using useMemo to ensure it only runs when the history array actually changes.

Suggested change
const hasStartedChat = history.some(
(item) => item.type === 'user' && item.text !== '/theme',
);
const hasStartedChat = useMemo(() => history.some(
(item) => item.type === 'user' && item.text !== '/theme',
), [history]);

@galz10 galz10 enabled auto-merge (squash) December 26, 2025 18:00
@galz10 galz10 merged commit bc40695 into release/v0.23.0-preview.1-pr-15494 Dec 26, 2025
19 checks passed
@galz10 galz10 deleted the hotfix/v0.23.0-preview.1/0.23.0-preview.2/preview/cherry-pick-9cdb267/pr-15494 branch December 26, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants