-
Notifications
You must be signed in to change notification settings - Fork 10.3k
fix(patch): cherry-pick 2995af6 to release/v0.21.0-preview.5-pr-15131 to patch version v0.21.0-preview.5 and create version 0.21.0-preview.6 #15153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patch): cherry-pick 2995af6 to release/v0.21.0-preview.5-pr-15131 to patch version v0.21.0-preview.5 and create version 0.21.0-preview.6 #15153
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick designed to update a preview release, specifically patching version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -2 B (0%) Total Size: 21.6 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cherry-picks a change to use a preview Gemini model when preview features are enabled. The implementation has a potential race condition where the model is selected before the previewFeatures flag is finalized, as it can be updated remotely during authentication. My review includes a comment with high severity to address this correctness issue, suggesting a refactor to determine the model after authentication is complete to ensure the correct model is used.
| model: settings.general?.previewFeatures | ||
| ? PREVIEW_GEMINI_MODEL | ||
| : DEFAULT_GEMINI_MODEL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential issue with how the model is selected. The model is determined here based on the settings.general?.previewFeatures value. However, for users authenticating with Google (USE_CCPA), the previewFeatures flag can be enabled later via experiments inside the config.refreshAuth() call.
When this happens, config.previewFeatures will become true, but the model will remain DEFAULT_GEMINI_MODEL because this logic is not re-evaluated. This can lead to an inconsistent state where preview features are enabled but the required preview model is not being used.
To resolve this, I recommend setting the model after refreshAuth has been called to ensure you are using the final value of previewFeatures. You can set the default model here, and then conditionally update it to PREVIEW_GEMINI_MODEL after the authentication block later in this function.
model: DEFAULT_GEMINI_MODEL,32f536b
into
release/v0.21.0-preview.5-pr-15131
This PR automatically cherry-picks commit 2995af6 to patch version v0.21.0-preview.5 in the preview release to create version 0.21.0-preview.6.