fix(cli):change the placeholder of input during the shell mode - #15135
Conversation
Summary of ChangesHello @JayadityaGit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a user experience issue within the CLI's shell mode by updating the input field's placeholder text. Previously, the placeholder incorrectly suggested general chat messages and file path references, which are not valid inputs in shell mode. The change ensures that when shell mode is active, the placeholder clearly instructs the user to 'Type your shell command', thereby aligning the UI with the actual functionality and reducing user frustration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where the input placeholder was incorrect in shell mode. My review focuses on refining the implementation to precisely match the UI shown in the pull request description's screenshots and improving the code's readability for future maintenance.
|
Thanks @galz10 and @jacob314 ! |
…ring the shell mode (google-gemini#15135)
Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>
…e-gemini#15135) Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>

Summary
When the user enters shell mode, the input placeholder continues to suggest normal chat usage. However, in this mode, the input only accepts shell commands.
As a result:
@for file path references also fails.Expected Behavior
Now the placeholder suggests what type of input is valid.
issues
#15136