Skip to content

fix(cli):change the placeholder of input during the shell mode - #15135

Merged
jacob314 merged 8 commits into
google-gemini:mainfrom
JayadityaGit:fix/UxShellMode
Dec 19, 2025
Merged

fix(cli):change the placeholder of input during the shell mode#15135
jacob314 merged 8 commits into
google-gemini:mainfrom
JayadityaGit:fix/UxShellMode

Conversation

@JayadityaGit

@JayadityaGit JayadityaGit commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Summary

When the user enters shell mode, the input placeholder continues to suggest normal chat usage. However, in this mode, the input only accepts shell commands.

As a result:

  • Entering regular messages fails.
Screenshot from 2025-12-16 12-37-34
  • Using @ for file path references also fails.
Screenshot from 2025-12-16 12-37-48
  • The UI implies capabilities that are not actually supported in shell mode, which can be confusing for users.
Screenshot from 2025-12-16 12-51-36

Expected Behavior

Now the placeholder suggests what type of input is valid.

Screenshot from 2025-12-16 12-46-47

issues

#15136

@JayadityaGit
JayadityaGit requested a review from a team as a code owner December 16, 2025 07:24
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @JayadityaGit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a user experience issue within the CLI's shell mode by updating the input field's placeholder text. Previously, the placeholder incorrectly suggested general chat messages and file path references, which are not valid inputs in shell mode. The change ensures that when shell mode is active, the placeholder clearly instructs the user to 'Type your shell command', thereby aligning the UI with the actual functionality and reducing user frustration.

Highlights

  • Improved User Experience in Shell Mode: The input placeholder in shell mode now accurately reflects that only shell commands are accepted, preventing user confusion and failed inputs.
  • Dynamic Placeholder Text: The placeholder text for the input field dynamically changes based on whether the CLI is in shell mode, Vim mode, or standard chat mode.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue where the input placeholder was incorrect in shell mode. My review focuses on refining the implementation to precisely match the UI shown in the pull request description's screenshots and improving the code's readability for future maintenance.

Comment thread packages/cli/src/ui/components/Composer.tsx
@JayadityaGit

Copy link
Copy Markdown
Contributor Author

Intially I made the change directly in the InputPrompt.tsx but the changes were not applied...during my research I have realized that Composer.tsx actually controls what should be shown in the InputPrompt.tsx
meme

@jacob314
jacob314 enabled auto-merge December 19, 2025 17:55
@jacob314
jacob314 added this pull request to the merge queue Dec 19, 2025
Merged via the queue into google-gemini:main with commit 181da07 Dec 19, 2025
20 checks passed
@JayadityaGit
JayadityaGit deleted the fix/UxShellMode branch December 20, 2025 06:22
@JayadityaGit

Copy link
Copy Markdown
Contributor Author

Thanks @galz10 and @jacob314 !

thacio added a commit to thacio/auditaria that referenced this pull request Jan 23, 2026
cocosheng-g pushed a commit that referenced this pull request May 6, 2026
Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>
@sripasg sripasg added the size/xs An extra small PR label Jun 2, 2026
software-0ficial pushed a commit to software-0ficial/gemini-cli that referenced this pull request Jul 9, 2026
…e-gemini#15135)

Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs An extra small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants