-
Notifications
You must be signed in to change notification settings - Fork 10.3k
fix(patch): cherry-pick 828afe1 to release/v0.20.0-preview.1-pr-14159 to patch version v0.20.0-preview.1 and create version 0.20.0-preview.2 #14733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patch): cherry-pick 828afe1 to release/v0.20.0-preview.1-pr-14159 to patch version v0.20.0-preview.1 and create version 0.20.0-preview.2 #14733
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick to update a preview release, primarily focusing on refactoring standard I/O handling within the CLI. The core change involves renaming a utility function for creating unpatched stdio streams and enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily refactors createInkStdio to the more aptly named createWorkingStdio and updates its usage across the codebase. This is a good improvement for clarity. The related changes, such as making TextOutput accept an output stream, enhance modularity and testability. However, I've identified one potential high-severity issue in the Zed integration where the removal of console output redirection could lead to lost logs or protocol interference. Overall, the refactoring is positive, but this one point needs attention.
| const { stdout: workingStdout } = createWorkingStdio(); | ||
| const stdout = Writable.toWeb(workingStdout) as WritableStream; | ||
| const stdin = Readable.toWeb(process.stdin) as ReadableStream<Uint8Array>; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the console redirection (console.log = console.error, etc.) might reintroduce a bug where log messages interfere with the Zed ACP (Agent-Client Protocol) communication over stdout. The original comment, which was also removed, explained that this redirection was necessary to ensure logs go to stderr. While consolePatcher is active, there are no listeners for coreEvents in the Zed integration path. This means logs might be lost, or if a default listener is ever added, they could be routed to stdout, breaking the protocol. Please consider restoring the redirection to ensure logs are correctly routed to stderr.
// Stdout is used to send messages to the client, so console.log/console.info
// messages to stderr so that they don't interfere with ACP.
console.log = console.error;
console.info = console.error;
console.debug = console.error;|
Size Change: +160 B (0%) Total Size: 21.5 MB ℹ️ View Unchanged
|
f9997f9
into
release/v0.20.0-preview.1-pr-14159
This PR automatically cherry-picks commit 828afe1 to patch version v0.20.0-preview.1 in the preview release to create version 0.20.0-preview.2.