Skip to content

Conversation

@gemini-cli-robot
Copy link
Collaborator

This PR automatically cherry-picks commit 828afe1 to patch version v0.20.0-preview.1 in the preview release to create version 0.20.0-preview.2.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated cherry-pick to update a preview release, primarily focusing on refactoring standard I/O handling within the CLI. The core change involves renaming a utility function for creating unpatched stdio streams and enhancing the TextOutput class to support configurable output streams. These changes improve the clarity and flexibility of how the application interacts with standard input/output, particularly in interactive and non-interactive contexts.

Highlights

  • Refactor createInkStdio to createWorkingStdio: The utility function createInkStdio has been renamed to createWorkingStdio across the codebase. This change better reflects its purpose of providing direct, unpatched access to process.stdout and process.stderr, which is useful for various output scenarios, not just Ink-based UIs.
  • Enhanced TextOutput Flexibility: The TextOutput class now accepts an optional outputStream in its constructor, defaulting to process.stdout. This allows consumers of TextOutput to specify a custom output stream, improving modularity and testability.
  • Streamlined Console Output in Zed Integration: The zed-integration module no longer redirects console.log, console.info, and console.debug to console.error. With the introduction of createWorkingStdio, direct output can be managed more cleanly without interfering with client communication.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily refactors createInkStdio to the more aptly named createWorkingStdio and updates its usage across the codebase. This is a good improvement for clarity. The related changes, such as making TextOutput accept an output stream, enhance modularity and testability. However, I've identified one potential high-severity issue in the Zed integration where the removal of console output redirection could lead to lost logs or protocol interference. Overall, the refactoring is positive, but this one point needs attention.

const { stdout: workingStdout } = createWorkingStdio();
const stdout = Writable.toWeb(workingStdout) as WritableStream;
const stdin = Readable.toWeb(process.stdin) as ReadableStream<Uint8Array>;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The removal of the console redirection (console.log = console.error, etc.) might reintroduce a bug where log messages interfere with the Zed ACP (Agent-Client Protocol) communication over stdout. The original comment, which was also removed, explained that this redirection was necessary to ensure logs go to stderr. While consolePatcher is active, there are no listeners for coreEvents in the Zed integration path. This means logs might be lost, or if a default listener is ever added, they could be routed to stdout, breaking the protocol. Please consider restoring the redirection to ensure logs are correctly routed to stderr.

  // Stdout is used to send messages to the client, so console.log/console.info
  // messages to stderr so that they don't interfere with ACP.
  console.log = console.error;
  console.info = console.error;
  console.debug = console.error;

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Size Change: +160 B (0%)

Total Size: 21.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 21.4 MB +160 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@scidomino scidomino enabled auto-merge (squash) December 8, 2025 19:45
@scidomino scidomino merged commit f9997f9 into release/v0.20.0-preview.1-pr-14159 Dec 8, 2025
22 checks passed
@scidomino scidomino deleted the hotfix/v0.20.0-preview.1/0.20.0-preview.2/preview/cherry-pick-828afe1/pr-14159 branch December 8, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants