Repository navigation
Conversation
Contributor
Author
|
Every tool needs similar improvement. This is only the beginning of a series of PRs. |
NTaylorMullen
approved these changes
Apr 18, 2025
evansenter
approved these changes
Apr 18, 2025
|
|
||
| private errorResult(params: LSToolParams, llmContent: string, returnDisplay: string): LSToolResult { | ||
| return { | ||
| entries: [], |
Collaborator
There was a problem hiding this comment.
If you want, you can delete the LSToolResult type and just return ToolResult. I don't believe we actully use this output today.
Contributor
Author
There was a problem hiding this comment.
I'll revisit this as a follow up.
keithballinger
pushed a commit
that referenced
this pull request
Jun 13, 2025
yaleh
pushed a commit
to yaleh/gemini-cli
that referenced
this pull request
Jun 29, 2025
viridivn
pushed a commit
to viridivn/gemini-cli
that referenced
this pull request
Jun 29, 2025
yewenchen
pushed a commit
to yewenchen/gemini-cli
that referenced
this pull request
Jul 8, 2025
skeshive
pushed a commit
that referenced
this pull request
Nov 18, 2025
skeshive
pushed a commit
that referenced
this pull request
Nov 18, 2025
Closed
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.