feat(core): Migrate chatCompressionService to model configs. - #12863
Merged
Conversation
|
Size Change: +1.05 kB (0%) Total Size: 21.1 MB
ℹ️ View Unchanged
|
joshualitt
force-pushed
the
jl/cleanup-1
branch
2 times, most recently
from
November 12, 2025 04:19
babf6e1 to
92f867c
Compare
joshualitt
force-pushed
the
jl/cleanup-1
branch
5 times, most recently
from
November 12, 2025 05:38
5751a1c to
1958d97
Compare
joshualitt
force-pushed
the
jl/cleanup-1
branch
4 times, most recently
from
November 20, 2025 22:29
779305c to
e7e7328
Compare
joshualitt
force-pushed
the
jl/cleanup-1
branch
from
November 22, 2025 01:39
e7e7328 to
8fc11a7
Compare
joshualitt
changed the title
BaseLlmClient.generateContent to obviate the need to use the contentGenerator directly.
joshualitt
commented
Nov 22, 2025
| }, | ||
| "chat-compression-3-pro": { | ||
| "model": "gemini-3-pro-preview", | ||
| "generateContentConfig": {} |
Contributor
Author
There was a problem hiding this comment.
This is intentional, the existing requests do not pass any settings
SandyTao520
approved these changes
Nov 24, 2025
kimjune01
added a commit
to kimjune01/gemini-cli-claude
that referenced
this pull request
Nov 24, 2025
Merge latest upstream changes from google-gemini/gemini-cli main branch. ## Merge Conflict Resolution **File:** packages/core/src/services/chatCompressionService.ts **Conflict:** Both branches modified the compression service API: - main: Migrated to new model config system (getBaseLlmClient, modelConfigKey) - feat/deliberate-compaction: Added goal-focused compression (userGoal parameter) **Resolution:** Combined both changes: - Used new model config API from main (getBaseLlmClient, modelStringToModelConfigAlias, abortSignal) - Preserved goal-focused enhancement (getChatCompressionPrompt(userGoal)) - Result: New API + goal awareness working together **Additional Changes:** - Updated chatCompressionService.test.ts to use new BaseLlmClient API - Changed all test mocks from getContentGenerator to getBaseLlmClient - Added BaseLlmClient import and proper type casts - Fixed linting: changed messagesPreserved/messagesCompressed to const - Build passes successfully ## Upstream Changes Merged From google-gemini/gemini-cli main (95693e2..d14779b): - feat(core): Land bool for alternate system prompt (google-gemini#13764) - feat(hooks): Hook Agent Lifecycle Integration (google-gemini#9105) - feat(hooks): Hook Event Handling (google-gemini#9097) - fix: Minor improvements to configs and getPackageJson (google-gemini#12510) - feat(hooks): Hook Telemetry Infrastructure (google-gemini#9082) - feat(core): Migrate chatCompressionService to model configs (google-gemini#12863) - Add session subtask in /stats command (google-gemini#13750) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mboshernitsan
pushed a commit
that referenced
this pull request
Nov 25, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Nov 26, 2025
danpalmer
pushed a commit
to danpalmer/gemini-cli
that referenced
this pull request
Nov 29, 2025
cocosheng-g
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup after landing model configs. Wires up the compression service to
BaseLlmClient.generateContent(https://github.com/google-gemini/gemini-cli/blob/main/packages/core/src/core/baseLlmClient.ts#L189).Related Issues
Related to #12590
How to Validate
Tests pass, evals are not negatively impacted.
Pre-Merge Checklist