Add a more explicit error when no parts returned
#180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a response has been blocked, the API will return a `Candidate` (with `finish_reason`, `safety_ratings`, etc) that does not have `Part`s. Given blocking is common enough, and we can identify this case, I've added a more explicit (and helpful?) error message to guide users if this happens.
github-actions
bot
added
status:awaiting review
These appear to be new changes, unrelated to this PR, but sure why not.
MarkDaoust
approved these changes
Jan 30, 2024
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a response has been blocked, the API will return a
Candidate(withfinish_reason,safety_ratings, etc) that does not have anyParts. Given blocking is common enough, and we can identify this case, I've added a more explicit (and helpful?) error message to guide users if this happens.LMK (or just push) if you think this could be worded clearer.
This should also fix the
TypeError: argument of type 'Part' is not iterableerror thrown in another (unknown?) case.