Add TokaMaker geometry interface - #2383
Open
fs2819 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to pass geometry information from TokaMaker directly (i.e. in memory) to TORAX via the 'tokamaker' geometry mode. The geometry information is calculated by TokaMaker (using the new
get_fsa()function) and then passed to TORAX as a dict of arrays.This geometry mode bypasses the saving and reading of
eqdskfiles, which is especially useful for the TokaMaker+TORAX pulse design workflow (which currently requires saving and loading hundreds ofeqdskfiles).This does not add a dependency for TokaMaker (or OFT) to TORAX. The geometry inputs are simply floats and NumPy arrays. The new
tokamaker_test.pyadded for this geometry type creates TokaMaker-like dict of arrays from a dummy cylindrical geometry, not requiring TokaMaker.