Add extra quantities to output IDS #1827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateoBell
force-pushed
the
imas_output_core_profiles_extra_quantities
branch
from
7817b0a to
905ad24
Compare
Collaborator
|
@jcitrin could you comment on some of the boundary value extrapolations done here? |
Improve readability
MateoBell
force-pushed
the
imas_output_core_profiles_extra_quantities
branch
from
1e0c0a6 to
971f37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping of some quantities which are not directly available on cell_plus_boundaries grid: j_parallel_total, j_parallel_ohmic, j_non_inductive, Z_avg for impurities and impurity_density_scaling factor.
IDS requires all profiles_1d to be on the same grid, therefore these quantities needed to be computed on the cell_plus_boundaries grid.
Question
To extend them, neighbouring values were copied as boundary values. Other possibility could be to use linear / polynomial extrapolation. What choice should be made for these quantities ?
Fixing wrongly mapped quantities:
j_totalandj_bootstrapcorresponds to their parallel current density. It was previously mapped from the toroidal values.Newly mapped quantities:
j_ohmic,j_non_inductive,j_phiz_ion_1d,n_impurity,n_i_volume_average