Skip to content

Minor suggestions for make_perturbed_fun #1342

@carlosgmartin

Description

@carlosgmartin

I have some minor suggestions for make_perturbed_fun:

  • Rename sigma to scale, which is more generic and self-explanatory. Note that Berthet et al. sometimes uses $\varepsilon$ for this, instead of $\sigma$.
  • Change the default value for num_samples from 1000 (a large arbitrary value) to 1. This is a less arbitrary value, and more common in stochastic optimization (where the objective function is itself stochastic).

If one or both of these are desirable, I can create a PR. Otherwise, this issue can be closed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions