feat: Implement Serialize for MCTSBot (#1257)#1466
Open
SH20RAJ wants to merge 2 commits intogoogle-deepmind:masterfrom
Open
feat: Implement Serialize for MCTSBot (#1257)#1466SH20RAJ wants to merge 2 commits intogoogle-deepmind:masterfrom
SH20RAJ wants to merge 2 commits intogoogle-deepmind:masterfrom
Conversation
- Added MaxGameStringLength to Game class in spiel.h - Exposed in python bindings (pyspiel.cc) - Implemented for Kuhn Poker - Fixed compilation errors in spiel.h and bridge.cc (MutexLock) - Added unit test
- Added Serialize/Deserialize to MCTSBot - Enabled mcts_test in CMakeLists.txt (was missing) - Added unit test for serialization verifying determinism
Collaborator
|
This one has a similar problem as the other: it includes changes from two other PRs. Each PR should be independently. Please remove the files that are not part of the MCTS serialization. One suggestion: when you are creating new branches, branch directly from master, not from a different non-master branch. |
Contributor
|
@SH20RAJ no need to recreate the PR, you did branching wrong, unfortunately, should've branched from
|
Contributor
Author
|
Thanks @lanctot and @alexunderch for the guidance! I'm still getting the hang of the workflow here. I will fix the branch by creating a clean branch from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Serialize and Deserialize for MCTSBot (Issue #1257).