Skip to content

Comments

Remove Python 3.10 support, update abseil version + change uses of MutexLock#1424

Merged
lanctot merged 13 commits intomasterfrom
lanctot-mutexlock-absl
Jan 12, 2026
Merged

Remove Python 3.10 support, update abseil version + change uses of MutexLock#1424
lanctot merged 13 commits intomasterfrom
lanctot-mutexlock-absl

Conversation

@lanctot
Copy link
Collaborator

@lanctot lanctot commented Jan 3, 2026

Delayed until we are ready to remove support for Python 3.10

  • Remove Python 3.10 support
  • Remove Intel Mac support (causing problems with abseil and PyTorch / JAX stopped supporting it in 2024)
  • Update abseil to version 20250814.1
  • Update uses of MutexLock(&lock) to MutexLock(lock)

@lanctot
Copy link
Collaborator Author

lanctot commented Jan 3, 2026

From https://github.com/google-deepmind/open_spiel/actions/runs/20676631630/job/59365126320 when building the Python 3.10 wheel:

        [ 35%] Built target absl_hashtablez_sampler
        /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
          164 |     shared_pools[i] = new RandenPoolEntry();
              |                       ^
        /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
        /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.13 or newer
          164 |     shared_pools[i] = new RandenPoolEntry();
              |                       ^
        /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
        2 errors generated.
        make[3]: *** [abseil-cpp/absl/random/CMakeFiles/absl_random_internal_entropy_pool.dir/internal/entropy_pool.cc.o] Error 1
        make[2]: *** [abseil-cpp/absl/random/CMakeFiles/absl_random_internal_entropy_pool.dir/all] Error 2
        make[2]: *** Waiting for unfinished jobs....
        [ 35%] Linking CXX static library libabsl_flags_program_name.a
        [ 35%] Built target absl_flags_program_name

Unfortunately we have to wait on this until Python 3.10 is removed.

@lanctot lanctot mentioned this pull request Jan 3, 2026
5 tasks
@lanctot
Copy link
Collaborator Author

lanctot commented Jan 3, 2026

We might remove Python 3.10 early since it's causing other issues and people can still use older versions. See discussion here: #1419 (comment)

@lanctot lanctot changed the title Update abseil version and change uses of MutexLock Remove Python 3.10 support, update abseil version + change uses of MutexLock Jan 5, 2026
@lanctot
Copy link
Collaborator Author

lanctot commented Jan 5, 2026

Same problem:

  [ 31%] Built target absl_crc_cord_state
  [ 31%] Building CXX object abseil-cpp/absl/random/CMakeFiles/absl_random_internal_entropy_pool.dir/internal/entropy_pool.cc.o
  /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
    164 |     shared_pools[i] = new RandenPoolEntry();
        |                       ^
  /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
  /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.13 or newer
    164 |     shared_pools[i] = new RandenPoolEntry();
        |                       ^
  /Users/runner/work/open_spiel/open_spiel/open_spiel/abseil-cpp/absl/random/internal/entropy_pool.cc:164:23: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic

This appears to be a problem with abseil and related to MacOS and only on Intel. I will try removing the Intel Mac wheels.

@lanctot lanctot added the imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! label Jan 12, 2026
@lanctot lanctot merged commit f3dd6e5 into master Jan 12, 2026
14 checks passed
@lanctot lanctot mentioned this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant