refactor(examples): add type hints to tic_tac_toe_qlearner#1411
Merged
lanctot merged 2 commits intogoogle-deepmind:masterfrom Jan 13, 2026
Merged
refactor(examples): add type hints to tic_tac_toe_qlearner#1411lanctot merged 2 commits intogoogle-deepmind:masterfrom
lanctot merged 2 commits intogoogle-deepmind:masterfrom
Conversation
Collaborator
|
Thanks! (for all the PRs). On type hints: we didn't have them for a long time because the minimum Python version we supported dated back to before type hints were common. Very happy to add them so long as the minimum version that we supports them (we're currently >= 3.10). I remember there was a switch for some things like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(examples): add type hints to tic_tac_toe_qlearner
Added type hints to the following functions:
pretty_boardcommand_line_actioneval_against_random_botsmainCleaned up imports and improved docstrings.
Verified by running the script locally.