Feat: Add native Windows pip installation support with automated CI/CD#1369
Closed
visheshrwl wants to merge 0 commit intogoogle-deepmind:masterfrom
Closed
Feat: Add native Windows pip installation support with automated CI/CD#1369visheshrwl wants to merge 0 commit intogoogle-deepmind:masterfrom
visheshrwl wants to merge 0 commit intogoogle-deepmind:masterfrom
Conversation
Collaborator
|
Wow, this is amazing, thank you! We're a bit back-logged at the moment, so apologies upfront: it will take a bit of time for us to look into this, but it's something I was hoping we'd have for a long time! |
Author
|
Thanks, glad to hear it! I know some tasks are failing at the moment, I mainly wanted to get a working draft out to unblock review and gather early feedback. I’ll keep iterating until it’s stable. |
Collaborator
|
Hi @visheshrwl just checking in. I see a few instances of the tests passing. Does it mean you got it working? A few changes have been made to these files since, I believe. And also there will be another one soon: #1418 Just curious in what state this is in and if you're still planning to work on it? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to resolve #804
feat: Add Windows pip installation support
Enables native Windows pip installation, eliminating 20+ manual setup steps