Add backward induction tests and Python implementation #1325
Conversation
|
@lanctot I have the Poc for 2nd part ready please let me know hoe to share? |
Did you close the previous Pull Request (PR)? There's no need to do that, btw -- you can simply modify your branch and when you push to the remote branch it will update the PR and we can rerun the tests. That gives use a way to have back-and-forth interaction within the same PR. What do you mean by "poc" .. piece of code? I think that should be a separate PR. Note that I am quite busy at work at the moment so there may be some delays in looking at these. |
|
I didnt wanted to close the previous pull request instead I accidentally did it. I am so sorry for that. Poc is proof of concept, I want to see if the prrof of concept works fundamentally as i am not comepletely sure it would work thats why i said Poc. Otherwise I feel not confident to do so. |
|
And I am seeing some of my tests are failing I will work and fix them Asap |
Ah, ok. Oh yes, don't hesitate to put the PR up early, even if it's not fully ready. That way we can more easily discuss it over github. But please do that as a separate PR. |
|
Thanks @lanctot |
|
@lanctot I have been trying to fix the test Issues but there is a lot of Linter errors coming specially when making Updates in Cmake. Is there some overview which I can follow to understand the workflow better. Any help would be appreciated |
The current problem is due to the PR missing some files: https://github.com/google-deepmind/open_spiel/pull/1325/files (Note that backward_induction.h is missing. Same with backward_induction.cc) Please add them and push the commit to the remote branch and I'll run the tests again. |
@lanctot Please check here I am sorry for the mess-up earlier