Fix MaxGameLength of TTT variants #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it. |
|
Hi @odanrc , I had to fix a breakage in the wheel tests. Could you pull changes from master and push the merge commit? |
odanrc
force-pushed
the
cleanup_ttt_1
branch
2 times, most recently
from
96f217a to
975ea4c
Compare
Can you do this again? (due to the pybind11 fixes last week.. ':)) |
The max game length of an ultimate TTT relies on the max length of its meta TTT game. Encapsulate this instead of re-implementing TicTacToe::MaxGameLenth in UltimateTTT::MaxGameLenth. Signed-off-by: odanrc <odanrc@yahoo.com.br>
The max game length of an phantom TTT relies on the max length of its underlying TTT game. Encapsulate this instead of re- implementing TicTacToe::MaxGameLenth in PhantomTTT::MaxGameLenth. Signed-off-by: odanrc <odanrc@yahoo.com.br>
lanctot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max game length of a TTT variant depends on the max length of its underlying TTT game. Encapsulate this instead of re-implementing TicTacToe::MaxGameLenth in the variants'::MaxGameLenth.