-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add *abrupt* phantom tic-tac-toe #1306
base: master
Are you sure you want to change the base?
Conversation
Regarding the failing tests: seems like a new issue in Dark Hex is causing a compilation problem that wasn't happening before. I am on vacation at the moment but will take a look when I get back. Once we fix it you can just pull the changes from master and retrigger the tests. |
Ok, this fix has been merged into master. Can you pull changes from master and push the merge commit to trigger the tests again? |
Thanks Marc! I rebased my branch to the latest master, should be good to go. |
Ok, the new failure looks legit. Did you modify the playthroughs manually (seems like some places were not updated)? If so, try to regenerate them using this script instead: https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/scripts/regenerate_playthroughs.sh |
@nathanlct did you see my last message? Can you update the playthroughs as instructed above (and pull changes from master -- there have been several major ones over the past two weeks) |
Sorry for the delay! I just pulled master and ran the regenerate_playthroughs script. |
Actually don't run the tests yet, I think I made a mistake. |
No problem, just let me know when. I am a bit behind on importing PRs and really busy with work lately, so no rush. |
@lanctot OK good to go now! |
This adds an abrupt variant to the Phantom TTT game, where playing on a non-empty cell stops the player's turn.
I copied the Dark Hex implementation which offers a choice between the classical or abrupt version of the game.