Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *abrupt* phantom tic-tac-toe #1306

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nathanlct
Copy link
Contributor

This adds an abrupt variant to the Phantom TTT game, where playing on a non-empty cell stops the player's turn.

I copied the Dark Hex implementation which offers a choice between the classical or abrupt version of the game.

@lanctot
Copy link
Collaborator

lanctot commented Feb 10, 2025

Regarding the failing tests: seems like a new issue in Dark Hex is causing a compilation problem that wasn't happening before.

I am on vacation at the moment but will take a look when I get back. Once we fix it you can just pull the changes from master and retrigger the tests.

@lanctot
Copy link
Collaborator

lanctot commented Feb 18, 2025

Regarding the failing tests: seems like a new issue in Dark Hex is causing a compilation problem that wasn't happening before.

I am on vacation at the moment but will take a look when I get back. Once we fix it you can just pull the changes from master and retrigger the tests.

Ok, this fix has been merged into master. Can you pull changes from master and push the merge commit to trigger the tests again?

@nathanlct
Copy link
Contributor Author

Thanks Marc! I rebased my branch to the latest master, should be good to go.

@lanctot
Copy link
Collaborator

lanctot commented Feb 19, 2025

Ok, the new failure looks legit.

Did you modify the playthroughs manually (seems like some places were not updated)? If so, try to regenerate them using this script instead: https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/scripts/regenerate_playthroughs.sh

@lanctot
Copy link
Collaborator

lanctot commented Mar 15, 2025

@nathanlct did you see my last message? Can you update the playthroughs as instructed above (and pull changes from master -- there have been several major ones over the past two weeks)

@nathanlct
Copy link
Contributor Author

Sorry for the delay! I just pulled master and ran the regenerate_playthroughs script.

@nathanlct nathanlct closed this Mar 18, 2025
@nathanlct nathanlct reopened this Mar 18, 2025
@nathanlct
Copy link
Contributor Author

Actually don't run the tests yet, I think I made a mistake.

@lanctot
Copy link
Collaborator

lanctot commented Mar 20, 2025

Actually don't run the tests yet, I think I made a mistake.

No problem, just let me know when.

I am a bit behind on importing PRs and really busy with work lately, so no rush.

@nathanlct
Copy link
Contributor Author

@lanctot OK good to go now!

@lanctot lanctot added the imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants