Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes planned for release of Ubuntu 23.04 (Lunar Lobster) / Python 3.11 support #1025

Merged
merged 30 commits into from
May 8, 2023

Conversation

lanctot
Copy link
Collaborator

@lanctot lanctot commented Mar 2, 2023

So far, this changes:

  • changes in dependencies
  • Add a new test for Python 3.11 to main tests
  • Add Python 3.11 wheel target
  • Add an install python 3.11 in install.sh (for 22.04)
  • Remove Python 3.7 support (corresponding test and wheel target)
  • Temporarily remove cvxopt from extra deps and disable related tests. Re-enable them later when binary wheels are available for Python 3.11. See Python 3.11 wheels cvxopt/cvxopt#228 for discussion.

@lanctot lanctot changed the title Changes planned for release of Ubuntu 23.04 (Lunic Lobster) / Python 3.11 support Changes planned for release of Ubuntu 23.04 (Lunar Lobster) / Python 3.11 support Mar 6, 2023
@lanctot
Copy link
Collaborator Author

lanctot commented Apr 17, 2023

@StochasticEntropy, it appears that there is a problem caused by the Jax version of DeepCFR depending on tensorflow_datasets. See here: https://github.com/deepmind/open_spiel/actions/runs/4714792415/jobs/8361347425.

I noticed the other implementations of DeepCFR don't rely on tfds, even your own TF2 implementation. Can this dependency be easily removed to fix the problem?

@lanctot
Copy link
Collaborator Author

lanctot commented May 4, 2023

@StochasticEntropy, it appears that there is a problem caused by the Jax version of DeepCFR depending on tensorflow_datasets. See here: https://github.com/deepmind/open_spiel/actions/runs/4714792415/jobs/8361347425.

I noticed the other implementations of DeepCFR don't rely on tfds, even your own TF2 implementation. Can this dependency be easily removed to fix the problem?

Resolved. I just needed to upgrade tensorflow_datasets.

@StochasticEntropy
Copy link
Contributor

@StochasticEntropy, it appears that there is a problem caused by the Jax version of DeepCFR depending on tensorflow_datasets. See here: https://github.com/deepmind/open_spiel/actions/runs/4714792415/jobs/8361347425.
I noticed the other implementations of DeepCFR don't rely on tfds, even your own TF2 implementation. Can this dependency be easily removed to fix the problem?

Resolved. I just needed to upgrade tensorflow_datasets.

Great, sorry I missed the question previously. tensorflow_datasets is used in jax to convert the tensorflow tensors from data loading to numpy for working with jax, which is not needed in the tf2 implementation where we work directly with the tensorflow tensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants