-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes planned for release of Ubuntu 23.04 (Lunar Lobster) / Python 3.11 support #1025
Conversation
…nto lanctot_ubuntu2304
@StochasticEntropy, it appears that there is a problem caused by the Jax version of DeepCFR depending on tensorflow_datasets. See here: https://github.com/deepmind/open_spiel/actions/runs/4714792415/jobs/8361347425. I noticed the other implementations of DeepCFR don't rely on tfds, even your own TF2 implementation. Can this dependency be easily removed to fix the problem? |
…nto lanctot_ubuntu2304
Resolved. I just needed to upgrade tensorflow_datasets. |
Great, sorry I missed the question previously. tensorflow_datasets is used in jax to convert the tensorflow tensors from data loading to numpy for working with jax, which is not needed in the tf2 implementation where we work directly with the tensorflow tensors. |
So far, this changes: