Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to failing python test #250

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

alberthli
Copy link
Contributor

When installing the python bindings using

python setup.py install

agent_test.py currently has one test failure:

ERROR: test_get_all_modes (__main__.AgentTest)
AgentTest.test_get_all_modes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/path/to/mujoco_mpc/python/mujoco_mpc/agent_test.py", line 338, in test_get_all_modes
    model = mujoco.MjModel.from_xml_path(str(model_path))
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Error: resource not found via provider or OS filesystem: '/path/to/mujoco_mpc/mjpc/tasks/quadruped/assets/calf.obj'

This PR skips this test (as is done for other tests which raise import errors) and also adds obj assets to the source paths (along with png and stl assets) so that they are built with the package after pulling the resources from mujoco_menagerie.

@alberthli alberthli marked this pull request as ready for review January 16, 2024 23:00
@erez-tom erez-tom enabled auto-merge January 19, 2024 14:49
@erez-tom erez-tom merged commit f481343 into google-deepmind:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants