Skip to content

Bug in iLQS: dim_actions and dim_parameters not updated. #264

Closed
@nimrod-gileadi

Description

@nimrod-gileadi

On this line, local variables dim_actions and dim_parameters are declared, which means that the assignment doesn't affect the member variables of the same name, so they're always zero.

This has two effects:

  1. Later down that function, mju_mulMatTMat is called with matrix sizes of 0, so there's no mapping from the iLQG nominal plan to the sampling nominal plan.
  2. The spline mapping computation happens every time, instead of just once.

The fix is simple, removing the int from the two lines. I tried it and it looks fine to me, but I saw no obvious impact on the performance of iLQS, so I wanted to check with Taylor if there's some model where this could have a significant impact, and to validate that recomputing the spline mapping is not necessary.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions