-
Notifications
You must be signed in to change notification settings - Fork 84
chore: bump toolchain and Mathlib to v4.18.0 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks! We are still letting the dust settle from a transition from having this be an internal to an open-source project, and until it has settled, switching the Lean version is probably a bad idea. Nevertheless, it's still very helpful to have this PR ready to go! |
FormalConjectures/ForMathlib/Algebra/Order/Group/Pointwise/Interval.lean
Outdated
Show resolved
Hide resolved
FormalConjectures/ForMathlib/Algebra/Order/Group/Pointwise/Interval.lean
Outdated
Show resolved
Hide resolved
Thanks! Perhaps also good to bump what is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebasing this to keep this up to date for when we need it
…erval.lean Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
…erval.lean Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
This PR updates the Lean toolchain and Mathlib dependency to v4.18.0.
This requires two additional changes:
Mathlib.Logic.Equiv.Fin
has been split, and the newly relevant import isMathlib.Logic.Equiv.Fin.Rotate
. I've also update the name of the relevant module inForMathlib/
I'd encourage anyone interested to re-golf that proof in a way that remains compatible with v4.18.0.