Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with premise of buyer in haggling environment #81

Conversation

RisingOrange
Copy link
Contributor

@RisingOrange RisingOrange commented Sep 7, 2024

There is an mistake in the premise of the buyer in the haggling environment.

Currently it says:
"Buyer is trying to buy some fruit from Seller. They are negotiating a price. Seller can sell the fruit for buyer_base_reward coins back in her home town."

It would make more sense if it would say this:
"Buyer is trying to buy some fruit from Seller. They are negotiating a price. Buyer can sell the fruit for buyer_base_reward coins back in her home town."

The buyer intends to sell the fruit (which she bought from the seller) in her home town.
This fits with the score of the buyer being the buyer_base_reward - the price they paid to buy the fruit:

if accepted:
rewards[self._buyer.name] = (
self._buyer_base_reward - self._action_to_reward[proposal]
)

Copy link

google-cla bot commented Sep 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jzleibo jzleibo assigned vezhnick and unassigned jzleibo Sep 9, 2024
Copy link
Collaborator

@vezhnick vezhnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@copybara-service copybara-service bot merged commit 9f21f9e into google-deepmind:main Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants