Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to pass node data json string when calling add_node_data. #169

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Allow users to pass node data json string when calling add_node_data. #169

merged 1 commit into from
Sep 12, 2024

Conversation

jinjingforever
Copy link
Collaborator

Also expose node data to the main APIs.

@github-actions github-actions bot removed the ci:run label Sep 12, 2024
yijie-yang
yijie-yang reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@yijie-yang yijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add this to the documentation?

@jinjingforever
Copy link
Collaborator Author

Should we also add this to the documentation?

Yes. I will update the documentation right after releasing the new version (just to reduce confusion).

@jinjingforever jinjingforever merged commit 376d443 into main Sep 12, 2024
6 of 7 checks passed
@jinjingforever jinjingforever deleted the jingjinnodedata branch September 12, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yijie-yang yijie-yang yijie-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinjingforever @yijie-yang