Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to 3.15.1 to work around Bazel 4 incompatibility #1652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnboiles
Copy link

I ran into this issue with building MediaPipe using Bazel 4.0.0. Apparently you need to use at least Protobuf 3.13 with Bazel 4.0.0.

This PR bumps Protobuf to 3.15.1.

I'm new to MediaPipe and Bazel. I'm not 100% sure I generated third_party/com_google_protobuf_fixes.diff correctly but it seems to work for me.

@google-cla
Copy link

google-cla bot commented Feb 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@johnboiles
Copy link
Author

@googlebot I signed it!

@johnboiles
Copy link
Author

Looks like rules_apple is only tested with Bazel 3.7 so that might also block fully moving to Bazel 4 until that's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant