Refactor ios face detector #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| static let notificationName = Notification.Name.init(rawValue: "com.google.mediapipe.inferenceConfigChanged") | ||
|
|
||
| private func postConfigChangedNotification() { |
There was a problem hiding this comment.
@khanhlvg Notification is used here as opposed to KVO in the object detector sample. I am okay with either. Do you have any preference?
There was a problem hiding this comment.
Let's use notification here because we don't need to know which value change. We just need to notify the observer that some config value has changed.
examples/face_detector/ios/FaceDetector/Extensions/UIImageOrientationExt.swift
Outdated
Show resolved
Hide resolved
examples/face_detector/ios/FaceDetector/ViewContoller/BottomSheetViewController.swift
Outdated
Show resolved
Hide resolved
khanhlvg
reviewed
Sep 6, 2023
examples/face_detector/ios/FaceDetector/ViewContoller/CameraViewController.swift
Outdated
Show resolved
Hide resolved
khanhlvg
reviewed
Sep 6, 2023
examples/face_detector/ios/FaceDetector/ViewContoller/CameraViewController.swift
Outdated
Show resolved
Hide resolved
khanhlvg
reviewed
Sep 6, 2023
examples/face_detector/ios/FaceDetector/ViewContoller/MediaLibraryViewController.swift
Outdated
Show resolved
Hide resolved
palrahul
pushed a commit
to palrahul/mediapipe
that referenced
this pull request
Sep 27, 2023
…_ios_face_detector Refactor ios face detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist
Please ensure the following items are complete before submitting a pull request:
Type of Change
Please check the relevant option below:
Screenshots
If applicable, please add screenshots to help explain your changes.
Additional Notes
Add any additional information or context about the pull request here.