Skip to content

test: delete minor unreachable code caused by t.Fatal#1285

Merged
yangkaa merged 1 commit into
goodrain:mainfrom
Abirdcfly:patch-1
Aug 10, 2022
Merged

test: delete minor unreachable code caused by t.Fatal#1285
yangkaa merged 1 commit into
goodrain:mainfrom
Abirdcfly:patch-1

Conversation

@Abirdcfly

Copy link
Copy Markdown
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Signed-off-by: Abirdcfly <fp544037857@gmail.com>


Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@yangkaa

yangkaa commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator

What problem is this to solve?

@Abirdcfly

Copy link
Copy Markdown
Contributor Author

What problem is this to solve?

The continue here means that the author thinks the loop can continue. But in fact it doesn't. So delete this false implication to avoid misunderstanding.

@yangkaa yangkaa changed the title delete minor unreachable code caused by t.Fatal test: delete minor unreachable code caused by t.Fatal Aug 10, 2022

@yangkaa yangkaa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangkaa yangkaa merged commit 654f3f6 into goodrain:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants