fix: move AAC fixtures out of cassettes directory#1517
Open
fix: move AAC fixtures out of cassettes directory#1517
Conversation
tychtjan
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1517 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 228 228
Lines 14930 14930
=======================================
Hits 11673 11673
Misses 3257 3257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tychtjan
force-pushed
the
fix/move-aac-fixtures-out-of-cassettes
branch
from
e2306c2 to
54b3f1a
Compare
jaceksan
requested changes
Apr 8, 2026
...s/gooddata-fdw/tests/import_foreign_schema/fixtures/import_compute_without_restrictions.yaml
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/data_sources/bigquery.yaml
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/data_sources/demo_generate_logical_model.yaml
Show resolved
Hide resolved
...ta-sdk/tests/catalog/fixtures/data_sources/demo_put_declarative_data_sources_connection.yaml
Outdated
Show resolved
Hide resolved
...es/gooddata-sdk/tests/catalog/fixtures/data_sources/demo_store_declarative_data_sources.yaml
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/users/list_users.yaml
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/users/test_api_tokens.yaml
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/workspace_content/label_elements.yaml
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/workspaces/add_metadata_locale.yaml
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/fixtures/workspaces/demo_clone_workspace.yaml
Outdated
Show resolved
Hide resolved
tychtjan
force-pushed
the
fix/move-aac-fixtures-out-of-cassettes
branch
5 times, most recently
from
204a10a to
7d3e08d
Compare
- Move tests/catalog/fixtures/aac/ to tests/catalog/unit_tests/aac_tests/ so make remove-cassettes no longer deletes static AAC test data - Add VCR normalizations for traceId, authenticationId/authId, bearerToken, cacheId, queryDurationMillis, and exportResult to eliminate transient diffs - Replace counter-based hash placeholders with fixed EXECUTION_NORMALIZED and EXPORT_NORMALIZED to avoid counter drift between recording and playback - Sort XML localization groups by id for deterministic XLIFF output - Bump docker-compose: Quiver v0.398.0, Pulsar 4.1.3, Redis 8.6.1 JIRA: DX-326 risk: low
JIRA: DX-326 risk: low
tychtjan
force-pushed
the
fix/move-aac-fixtures-out-of-cassettes
branch
from
7d3e08d to
9e0d663
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/catalog/fixtures/aac/totests/catalog/aac_fixtures/somake remove-cassettesno longer deletes static AAC test datatest_aac.pyandtest_gdc.pyProblem
The
remove-cassettestarget inproject_common.mkruns:This deletes all YAML files under
fixtures/, including the AAC test fixtures added in #1508. Those files are static test data (not VCR recordings), so they shouldn't be wiped.JIRA: DX-326