add support for warehouse schemas#393
Merged
martiner merged 1 commit intogooddata:masterfrom Nov 1, 2016
Tantalor93:obe-schemas
Merged
add support for warehouse schemas#393martiner merged 1 commit intogooddata:masterfrom Tantalor93:obe-schemas
martiner merged 1 commit intogooddata:masterfrom
Tantalor93:obe-schemas
Conversation
martiner
suggested changes
Oct 30, 2016
| private Map<String, String> links; | ||
|
|
||
| @JsonCreator | ||
| public WarehouseSchema(@JsonProperty("name") String name, |
Contributor
Author
There was a problem hiding this comment.
changed to private
| public class WarehouseServiceIT extends AbstractGoodDataIT { | ||
|
|
||
| private static final String TITLE = "Test"; | ||
| private static final String SCHEMA_NAME = "default"; |
Contributor
There was a problem hiding this comment.
what is the default schema? is it something always present? maybe user would use some handy get method in the service?
Contributor
Author
There was a problem hiding this comment.
yes, default schema always exists in warehouse. Added method getDefaultWarehouseSchema to the service.
martiner
suggested changes
Nov 1, 2016
| public static final String URI = WarehouseSchemas.URI + "/{name}"; | ||
| public static final UriTemplate TEMPLATE = new UriTemplate(URI); | ||
|
|
||
| private String name; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.