⚡ Add input and remove targetName #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input as a parameter to `mkPlatform` for C. This makes it possible to use a different component target when components are listed as dependencies in other components. Remove `targetName` as a parameter sent to the `mk*` functions in C. `targetName` is only a string and does not represent the expected information since it can sometimes refer to what is being used from other components and does not reflect any state on the current component. Instead, accept `stdenv` as a parameter and use that one. Also fix so that the spliced stdenv is the stdenv actually used.
sakarias88
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input as a parameter to
mkPlatformfor C. This makes it possible to use a different component target when components are listed as dependencies in other components.Remove
targetNameas a parameter sent to themk*functions in C.targetNameis only a string and does not represent the expected information since it can sometimes refer to what is being used from other components and does not reflect any state on the current component. Instead, acceptstdenvas a parameter and use that one.Also fix so that the spliced stdenv is the stdenv actually used.