Expose lifetime stack as class attr, add base test suite #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2022
goodboy
force-pushed
the
lifetime_stack_tests
branch
from
a109b90 to
c28557a
Compare
goodboy
force-pushed
the
we_bein_all_matchy
branch
from
fd541a6 to
f07ddf1
Compare
goodboy
force-pushed
the
lifetime_stack_tests
branch
from
c28557a to
2bc75e8
Compare
goodboy
force-pushed
the
we_bein_all_matchy
branch
from
f07ddf1 to
10eeda2
Compare
goodboy
force-pushed
the
lifetime_stack_tests
branch
from
2bc75e8 to
e609183
Compare
Owner
Author
|
Just needs a nooz file. |
guilledk
approved these changes
Sep 16, 2022
Owner
Author
or i'll forget about it 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose the runtime-lifetime exit stack as a
Actor.lifetime_stackand add a small test suite that ensures it cleans up local filesystem files on crashes and cancels in a child actor.Note: this is an undocumented API used in
pikerand is likely to be updated/change.