Spike add password change decoration for authentication token renewal #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix RSpec expectation Minor fix Cucumber step misspelling
Marking this integration test as pending increses the visibility of the ActsAsTokenAuthenticatable#renew_authentication_token! unit tests. This commit must be reverted once the test suite is green again.
|
Relevant Devise code:
|
This reverts commit f358a36217a017e7290a6fd928e270a7ec5be580.
gonzalo-bulnes
force-pushed
the
fix-authentication-token-not-renewed-after-password-change
branch
from
1f1ece4 to
998c5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer
In order to get an insight of which way could lead to effectively decorating the
Devise::PasswordsController#updateactionAnd to be able to decide which is the better way to write the corresponding RSpec example
I want to explore some of the possible implementations
This spike is part of #40.