visionOS support (new method) #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalezreal
reviewed
Sep 3, 2023
gonzalezreal
reviewed
Sep 3, 2023
There was a problem hiding this comment.
Hey @Rminsh,
Thanks for this contribution. I only left a minor remark about the changes in Package.swift. Other than that, it looks great!
|
@gonzalezreal Thanks, vision's version check is removed , Please check again. |
Closed
bartlomiejzabicki
pushed a commit
to Bartlomiej-Zabicki-Mobile-Developer/MarkdownUI
that referenced
this pull request
Oct 8, 2023
* Changed UIKit OS checks for global use (visionOS) * Added visionOS to package.swift * Removed visionOS version in Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the project is using the UIKit most of the times (iOS, watchOS, tvOS, visionOS, mac catalyst) instead of specifying os check types, we should use
#if canImport(UIKit).So in future if apple added any type of device (such as glasses 😁) and that device can use UIKit, we don't have to change anything (even we don't have to specify any swift version check).
Also this can be removed from
package.swiftif there is any problem with Xcode 14 (couldn't confirm that):Cheers