vg/vgsvg: drop fontMap, use informations from font.Font#704
vg/vgsvg: drop fontMap, use informations from font.Font#704sbinet wants to merge 4 commits intogonum:masterfrom
Conversation
|
PTAL @stippi2 |
kortschak
left a comment
There was a problem hiding this comment.
This looks like it has broken text alignment; the width of text in the test golden values is greater and so now the text is not centred and extends beyond the bounds of the plot.
|
@kortschak what do you see? could it be that the Liberation fonts are not available to your browser? |
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 71.91% 71.96% +0.05%
==========================================
Files 56 58 +2
Lines 4957 5230 +273
==========================================
+ Hits 3565 3764 +199
- Misses 1206 1272 +66
- Partials 186 194 +8
Continue to review full report at Codecov.
|
|
It's entirely possible that the installed fonts impacts on this. There should probably be some documentation explaining how to ensure that fonts are available for SVG-rendered plots with this change. We're bound to get issues otherwise. |
|
you're probably right. perhaps this could be addressed with embedding fonts? |
|
@kortschak |
|
Are they independent? If they are, then looking at the PR adding embedding and then rebasing this only that once merged would be the best I think. |
|
they are independent. |
|
actually, it's a bit more intertwined than I remembered. (the coupling is in the naming taxonomy of fonts) |
This CL drops the use of the internal fontMap that was associating some pre-defined set of fonts with a set of SVG naming schemes (derived from PostScript). Instead, use the informations contained in plot/font.Font to derive the expected SVG font-family (and friends) font style string. Updates gonum#702.
|
superseded by #705 |




This CL drops the use of the internal fontMap that was associating some
pre-defined set of fonts with a set of SVG naming schemes (derived from
PostScript).
Instead, use the informations contained in plot/font.Font to derive the
expected SVG font-family (and friends) font style string.
Updates #702.
Please take a look.