Skip to content

modules: update for gonum v0.9.0 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

modules: update for gonum v0.9.0 #84

wants to merge 1 commit into from

Conversation

kortschak
Copy link
Member

Please take a look.

@kortschak
Copy link
Member Author

kortschak commented Mar 10, 2021

Passes locally, still fails on remote build infrastructure.

$ CGO_LDFLAGS="-L/usr/local/lib -lopenblas" go test -count=1 ./...
ok  	gonum.org/v1/netlib/blas/netlib	1.525s
?   	gonum.org/v1/netlib/internal/binding	[no test files]
?   	gonum.org/v1/netlib/lapack/lapacke	[no test files]
ok  	gonum.org/v1/netlib/lapack/netlib	48.299s

@vladimir-ch
Copy link
Member

I'm not sure it's correct in DrotmgTest to multiply y from Drotm with rd2 from Drotmg. Not multiplying won't turn it into 0 but the result will be 3 orders smaller (~1e-14) which is easier to accept as zero.

In the Dlapy2 test I think we'll have to use a tolerance in the test instead of strict equality.

@kortschak
Copy link
Member Author

Do you want to fix those in testblas/testlapack?

@vladimir-ch
Copy link
Member

Sorry, I misunderstood, my previous comment is wrong. But now I'm wondering whether the test should pass {sqrt(d1)*x1, sqrt(d2)*y1} to Drotm instead of {x1,y1} and multiplying afterwards. But if the failure can only be reproduced on GitHub and we have to push to gonum repo and run the test in this repo, the test cycle is very long and unconvenient ...

@kortschak
Copy link
Member Author

In situations like this, I'd do experiments in this repo in the PR with a temporary copy of testblas in this repo. Still slow, but not quite as horrific is handling two modules and requiring replaces in the go.mod.

@vladimir-ch
Copy link
Member

Closing because superseded by #92. I will handle any remote build failures there.

@vladimir-ch vladimir-ch closed this Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants