Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use 'slug' property instead of tag's 'name' to create the URL #98

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: use 'slug' property instead of tag's 'name' to create the URL #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/BookmarkCard/BookmarkCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
<span class="font-sans text-xs font-semibold">#</span>
{#if bookmark.tags}
{#each bookmark.tags as tag (tag.id)}
<a href={`/tags/${tag.name}`} class="link font-sans text-xs">{tag.name}</a>
<a href={`/tags/${tag.slug}`} class="link font-sans text-xs">{tag.name}</a>
{/each}
{/if}
<button title="Add new tag" class="link-hover link font-sans text-xs text-gray-400"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/BookmarkListItem/BookmarkListItem.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
{#if bookmark.tags}
{#each bookmark.tags as tag (tag.id)}
<a
href={`/tags/${tag.name}`}
href={`/tags/${tag.slug}`}
class="link w-full max-w-[8rem] whitespace-nowrap font-sans text-xs hover:text-secondary"
>{tag.name}</a
>
Expand Down
Loading